Python linter checks in the GitHub Travis CI build

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
User avatar
Dilvish
AI Lead, Programmer
Posts: 4713
Joined: Sat Sep 22, 2012 6:25 pm

Python linter checks in the GitHub Travis CI build

#1 Post by Dilvish » Fri Mar 09, 2018 6:39 pm

We are adding a stage of python code style checking into our GitHub Travis CI build process; PR's should not be merged if they are failing this stage. If a PR of yours fails this stage, please review the associated report (found via the respective "Details" link in the CI section of your PR page), make the required changes and check locally, then update your PR.

There are a variety of ways to check for such things locally; in general we recommend doing your python coding with PyCharm, which supports such checking in a few ways.

If you have questions about this general process, or about particular error reporting you get from this, feel free to post those questions here. Once resolved I may curate (edit or delete) any such posts here in order to keep this thread concise/clean.

(Related to the above, I invite comment on this initial message, I'll then edit and curate the thread).
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Gault.Drakkor
Space Floater
Posts: 40
Joined: Sat Jul 01, 2017 4:54 am

Re: Python linter checks in the GitHub Travis CI build

#2 Post by Gault.Drakkor » Sat Mar 10, 2018 8:07 am

Could you please add links/info as to what is the style you are checking for?

pep8? pep8 with exceptions? Do you have a pylintrc for pylint?

User avatar
Cjkjvfnby
AI Contributor
Posts: 452
Joined: Tue Jun 24, 2014 9:55 pm

Re: Python linter checks in the GitHub Travis CI build

#3 Post by Cjkjvfnby » Sat Mar 10, 2018 9:17 am

Could you please add links/info as to what is the style you are checking for?
https://github.com/freeorion/freeorion/ ... tyle-check
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Gault.Drakkor
Space Floater
Posts: 40
Joined: Sat Jul 01, 2017 4:54 am

Re: Python linter checks in the GitHub Travis CI build

#4 Post by Gault.Drakkor » Sat Mar 10, 2018 5:37 pm

Cjkjvfnby wrote:
Could you please add links/info as to what is the style you are checking for?
https://github.com/freeorion/freeorion/ ... tyle-check
Divlish could you please include something along the lines of:
"Our info page for the current style checking tool and the project configuration for the tool."

TIA.

Cjkjvfnby. Thank you. That is the information I was wanting to know.

Post Reply