[Patch] Lock windows
Moderator: Committer
[Patch] Lock windows
This allows to Lock the message window.
Require pin.png and pinned.png to be in /default/data/art/icons/buttons
Disccussion: viewtopic.php?f=6&t=8951
Require pin.png and pinned.png to be in /default/data/art/icons/buttons
Disccussion: viewtopic.php?f=6&t=8951
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
-
- pinned.png (1.87 KiB) Viewed 2012 times
-
- pin.png (1.94 KiB) Viewed 2012 times
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
If you're posting "art" (as debatable as it may be in this case), you should also note that you release it under the CC-BY-SA 3.0 license.
Re: [Patch] Lock windows
Will do, I'll put the in my signature as well.
For the record: All art and artwork is under CC-BY-SA 3.0 license.
For the record: All art and artwork is under CC-BY-SA 3.0 license.
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
Generally seems OK.
Putting the button into CUIWnd but then only implementing the behaviour in MessageWnd is odd, though.
Putting the button into CUIWnd but then only implementing the behaviour in MessageWnd is odd, though.
Re: [Patch] Lock windows
I've changed that now. It's implemented in CuiWnd.
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
Please remove all tabs and replace with 4 spaces.
If resizing is disabled while pinned, the mouseover highlight of the resize tab at the bottom right should be disabled.
If resizing is disabled while pinned, the mouseover highlight of the resize tab at the bottom right should be disabled.
Re: [Patch] Lock windows
Tabs removed.
Window now has m_resizable set to false when the window is pinned.
Window now has m_resizable set to false when the window is pinned.
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
Committed the button icons and CUIWnd changes.
Can you provide another patch that makes as many UI windows as is reasonable pinnable?
Sitrep, Messages, Empires, Objects, FleetWnd, Pedia (on map and subscreens), various windows on the design, research, and production screens?
Can you provide another patch that makes as many UI windows as is reasonable pinnable?
Sitrep, Messages, Empires, Objects, FleetWnd, Pedia (on map and subscreens), various windows on the design, research, and production screens?
Re: [Patch] Lock windows
Will do. Was about to ask what windows those should be, but I'll do the list you suggested first.
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Re: [Patch] Lock windows
Hello the committed patch makes my compiler warn about member initialization order:Geoff the Medio wrote:Committed the button icons and CUIWnd changes.
Code: Select all
In file included from /home/vince/repo/upstream/freeorion/FreeOrion/UI/CUIWnd.cpp:3:0:
/home/vince/repo/upstream/freeorion/FreeOrion/UI/CUIWnd.h: In constructor ‘CUIWnd::CUIWnd(const string&, GG::X, GG::Y, GG::X, GG::Y, GG::Flags<GG::WndFlag>)’:
/home/vince/repo/upstream/freeorion/FreeOrion/UI/CUIWnd.h:151:27: warning: ‘CUIWnd::m_minimize_button’ will be initialized after [-Wreorder]
CUI_MinRestoreButton* m_minimize_button; //!< the minimize/restore button
^
/home/vince/repo/upstream/freeorion/FreeOrion/UI/CUIWnd.h:142:10: warning: ‘bool CUIWnd::m_pinable’ [-Wreorder]
bool m_pinable; //!< true if the window is able to be pinned
^
/home/vince/repo/upstream/freeorion/FreeOrion/UI/CUIWnd.cpp:136:1: warning: when initialized here [-Wreorder]
CUIWnd::CUIWnd(const std::string& t, GG::X x, GG::Y y, GG::X w, GG::Y h, GG::Flags<GG::WndFlag> flags) :
All the patches I'll provide for freeorion will be released under the GPL v2 or later license.
Let's unleash the dyson forest powa!
Let's unleash the dyson forest powa!
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
Hopefully fixed...vincele wrote:...warn about member initialization order...
Re: [Patch] Lock windows
I've added pinning to a few windows that were pretty straightforward, working on Pedia now.
Message
ModeratorActions
ObjectList
PlayerList
SitRep
Message
ModeratorActions
ObjectList
PlayerList
SitRep
- Attachments
-
[The extension patch has been deactivated and can no longer be displayed.]
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: [Patch] Lock windows
Committed.
Can you also add mouseover responses to the pin button? (Like how the close button responds to having the mouse cursor over it)
Can you also add mouseover responses to the pin button? (Like how the close button responds to having the mouse cursor over it)
Re: [Patch] Lock windows
Is this going into 0.4.4 or just into Trunk for 0.4.4+ Because it looks like a nice little feature to have.
Mat Bowles
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.
Any code or patches in anything posted here is released under the CC and GPL licences in use for the FO project.
Re: [Patch] Lock windows
I made the mouseover work. The code was already there for X button.
I needed to add additional images, I had to tweak the originals for contrast however, so the pin.png and pinned.png files should be replaced as well.
I needed to add additional images, I had to tweak the originals for contrast however, so the pin.png and pinned.png files should be replaced as well.
- Attachments
-
- buttons.zip
- (6.88 KiB) Downloaded 110 times
-
[The extension patch has been deactivated and can no longer be displayed.]
Code, justify, code - Pitr
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.
Attached patches are released under GPL 2.0 or later, artwork and such are released under CC-BY-SA 3.0 license.