6142 (Dev build)
Moderator: Oberlus
Forum rules
Always mention the exact version of FreeOrion you are testing.
When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Always mention the exact version of FreeOrion you are testing.
When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
6142 (Dev build)
Having a colony ship present at a system will display the "Colonize" button and also (unexpectedly) a all-zero numbered production/research/etc planet details lines.
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
Re: 6142 (Dev build)
That doesn't always happen to you does it? I think the meters things has shown up very very rarely for me. Something related that happened to me last week is that a couple Gas Giants I had been planning on outposting and converting to artificial planets had showed up as owned by me before I thought it should, but ok, I went ahead and queued up the Artificial Planets at both those spots. The next turn, the planets were back to showing as unowned, and the ProductionQueue panels for the Artificial Planets were showing as completing 'Never', because of course I can't build where I don't own. I outposted them a couple turns later & then production on the Artificial Planets resumed fine, but it was a very weird experience.
I think it all stems from the old code that was used to make the colonization button estimates before the autoSelection of colony ships code was written -- it looks to me like it goes through and temporarily assigns ownership to the Player, for all unowned planets, then calculates their meters, leaves the meters in place to be referenced later if the colony button code needs it, and assigns back ownership of the planets to -1. I rather suspect that all that code accomplishes now is generating lag and occasional glitches like you and I have just run into.
I just now tried putting a return at the beginning of void MapWnd::UpdateMeterEstimates(const std::vector<int>& objects_vec), and everything still seemed to work just fine, but I haven't really tested that out thoroughly yet, and theres also a lot of other related calls that can probably be done away with also.
I think it all stems from the old code that was used to make the colonization button estimates before the autoSelection of colony ships code was written -- it looks to me like it goes through and temporarily assigns ownership to the Player, for all unowned planets, then calculates their meters, leaves the meters in place to be referenced later if the colony button code needs it, and assigns back ownership of the planets to -1. I rather suspect that all that code accomplishes now is generating lag and occasional glitches like you and I have just run into.
I just now tried putting a return at the beginning of void MapWnd::UpdateMeterEstimates(const std::vector<int>& objects_vec), and everything still seemed to work just fine, but I haven't really tested that out thoroughly yet, and theres also a lot of other related calls that can probably be done away with also.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0
Re: 6142 (Dev build)
I've played 3-4 games now (Full installer, Win7) and tried reinstalling the game inbetween:
The game got noticeably slower/laggier.
In previous versions the game was playable on my system up to round ~300.
Now, the noticable lag/unresponsiveness starts already at round ~160. Approaching round ~240 it is unplayable. The production/research window is unusable, double clicks arent recognized anymore.
My game setup is always ~160 systems, 7 AI.
The game got noticeably slower/laggier.
In previous versions the game was playable on my system up to round ~300.
Now, the noticable lag/unresponsiveness starts already at round ~160. Approaching round ~240 it is unplayable. The production/research window is unusable, double clicks arent recognized anymore.
My game setup is always ~160 systems, 7 AI.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: 6142 (Dev build)
What previous versions?MiniMe wrote:In previous versions...
Re: 6142 (Dev build)
No, it doesn't... I'm trying to narrow down the parameters that make it happen. When it happens, it's consistent. When it doesn't, it's also consistent. I'll post a save file if I find it again.That doesn't always happen to you does it?
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
Re: 6142 (Dev build)
Repro-ed. Two colony bases on Rigel 1 just completed, and the auto-colonize now puts the "owned planet" dressings on the two colonizable planets. Save game attached (7zipped).
- Attachments
-
- colonize_display_bug.7z
- (89.19 KiB) Downloaded 88 times
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
Re: 6142 (Dev build)
Another instance of this. Save and screen shots attached.
Two outpost bases just completed. The 2 gas giants that I don't own start showing 'window dressings' of ownership in the presence of the outpost bases. I am also allowed to give move orders to the outpost bases (they are not outpost ships). (I think the move order is because I have starlane speed researched )
Two outpost bases just completed. The 2 gas giants that I don't own start showing 'window dressings' of ownership in the presence of the outpost bases. I am also allowed to give move orders to the outpost bases (they are not outpost ships). (I think the move order is because I have starlane speed researched )
- Attachments
-
- colonize_display_bug2.7z
- (96.2 KiB) Downloaded 88 times
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
Re: 6142 (Dev build)
It seems to require two colony ships/bases at the same location to confuse it. Possibly might require two planets and/or planets of the same time.
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
Re: 6142 (Dev build)
That situation I mentioned running into also involved two colony bases / planets in the same system, so I think you're on to something there...yandonman wrote:It seems to require two colony ships/bases at the same location to confuse it. Possibly might require two planets and/or planets of the same time.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: 6142 (Dev build)
Is the tech eta number on the tree misplaced for anyone else? It used to be in the circle, but it seems to be shifted over for me now, and I don't recall making any relevant changes myself...
- Attachments
-
- tech ETA number
- tech_eta.png (10.63 KiB) Viewed 1233 times
Re: 6142 (Dev build)
I hadn't noticed before, but yes, checking now I see that it is, the same as yours.Geoff the Medio wrote:Is the tech eta number on the tree misplaced for anyone else? ...
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: 6142 (Dev build)
It works with 6102 (after tweaks to make it build with other recent include files rearrangement).
Re: 6142 (Dev build)
Performance: Colonizing 3 asteroid belts at the same time with exobots had this effect:
Here's the extended log:
Code: Select all
2013-06-15 18:53:08,736 DEBUG Client : MapWnd::InitTurn time: 5434
Code: Select all
2013-06-15 18:53:03,302 DEBUG Client : Initializing turn 141
2013-06-15 18:53:03,304 DEBUG Client : Universe::InitMeterEstimatesAndDiscrepancies
2013-06-15 18:53:03,305 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,346 DEBUG Client : Type times: planet species: 13 ship species: 16 specials: 2 techs: 2 buildings: 1 hulls/parts: 6 fields: 1
2013-06-15 18:53:03,355 DEBUG Client : Universe::ExecuteEffects time: 9
2013-06-15 18:53:03,356 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 341 objects time: 52
2013-06-15 18:53:03,356 DEBUG Client : MapWnd::UpdateMeterEstimates
2013-06-15 18:53:03,360 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,400 DEBUG Client : Type times: planet species: 12 ship species: 17 specials: 2 techs: 2 buildings: 1 hulls/parts: 6 fields: 0
2013-06-15 18:53:03,409 DEBUG Client : Universe::ExecuteEffects time: 9
2013-06-15 18:53:03,410 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 341 objects time: 51
2013-06-15 18:53:03,410 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,456 DEBUG Client : Type times: planet species: 14 ship species: 18 specials: 3 techs: 2 buildings: 2 hulls/parts: 6 fields: 1
2013-06-15 18:53:03,461 DEBUG Client : Universe::ExecuteEffects time: 5
2013-06-15 18:53:03,461 DEBUG Client : MapWnd::InitTurnRendering
2013-06-15 18:53:03,520 DEBUG Client : MapWnd::InitSystemRenderingBuffers
2013-06-15 18:53:03,529 DEBUG Client : MapWnd::InitSystemRenderingBuffers time: 9
2013-06-15 18:53:03,529 DEBUG Client : MapWnd::InitStarlaneRenderingBuffers
2013-06-15 18:53:03,550 DEBUG Client : MapWnd::InitTurnRendering time: 89
2013-06-15 18:53:03,554 DEBUG Client : MapWnd::UpdateMeterEstimates
2013-06-15 18:53:03,554 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,584 DEBUG Client : Type times: planet species: 8 ship species: 16 specials: 1 techs: 1 buildings: 0 hulls/parts: 4 fields: 0
2013-06-15 18:53:03,585 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 5 objects time: 31
2013-06-15 18:53:03,586 DEBUG Client : MapWnd::UpdateMeterEstimates
2013-06-15 18:53:03,586 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,616 DEBUG Client : Type times: planet species: 7 ship species: 16 specials: 2 techs: 1 buildings: 0 hulls/parts: 4 fields: 0
2013-06-15 18:53:03,617 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 5 objects time: 31
2013-06-15 18:53:03,617 DEBUG Client : MapWnd::UpdateMeterEstimates
2013-06-15 18:53:03,617 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:03,647 DEBUG Client : Type times: planet species: 8 ship species: 15 specials: 2 techs: 1 buildings: 0 hulls/parts: 4 fields: 0
2013-06-15 18:53:03,648 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 5 objects time: 31
2013-06-15 18:53:03,662 DEBUG Client : ========= Production Update for empire: 1 ========
2013-06-15 18:53:03,666 DEBUG Client : ProductionQueue::Update: Simulating future turns of production queue
2013-06-15 18:53:03,668 DEBUG Client : MapWnd::InitStarlaneRenderingBuffers
2013-06-15 18:53:03,687 DEBUG Client : MapWnd::InitStarlaneRenderingBuffers time: 19
2013-06-15 18:53:03,697 DEBUG Client : ========= Production Update for empire: 2 ========
2013-06-15 18:53:03,698 DEBUG Client : ========= Production Update for empire: 3 ========
2013-06-15 18:53:03,698 DEBUG Client : not enough PP to be worth simulating future turns production. marking everything as never complete
2013-06-15 18:53:03,698 DEBUG Client : ========= Production Update for empire: 4 ========
2013-06-15 18:53:03,698 DEBUG Client : not enough PP to be worth simulating future turns production. marking everything as never complete
2013-06-15 18:53:03,698 DEBUG Client : MapWnd::InitTurn updating resource pools time: 43
2013-06-15 18:53:03,703 DEBUG Client : Tech Tree Layout Preparing Tech Data
2013-06-15 18:53:03,810 DEBUG Client : Tech Tree Layout Doing Graph Layout
2013-06-15 18:53:03,810 DEBUG Client : TechTreeLayout::DoLayout creaing place holder nodes...
2013-06-15 18:53:03,811 DEBUG Client : Tech Tree Layout Creating Panels
2013-06-15 18:53:03,814 DEBUG Client : Tech Tree Layout Done
2013-06-15 18:53:03,822 DEBUG Client : MapWnd::InitTurn research wnd refresh time: 123
2013-06-15 18:53:06,561 DEBUG Client : MapWnd::InitTurn sidepanel refresh time: 2739
2013-06-15 18:53:06,562 DEBUG Client : ProductionWnd::UpdateQueue()
2013-06-15 18:53:07,602 DEBUG Client : BuildDesignatorWnd::BuildSelector::Refresh()
2013-06-15 18:53:07,626 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:07,655 DEBUG Client : Type times: planet species: 6 ship species: 16 specials: 1 techs: 1 buildings: 1 hulls/parts: 4 fields: 0
2013-06-15 18:53:07,655 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 1 objects time: 29
2013-06-15 18:53:07,655 DEBUG Client : UniverseObject::MoveTo : Placing object "" off the map area.
2013-06-15 18:53:07,656 DEBUG Client : Object was removed: Ship -2: owner: 1 created on turn: 141 specials: Meters: Max Fuel: Cur: 4 Init: 0 Max Shield: Cur: 0 Init: 0 Max Structure: Cur: 10 Init: 0 Fuel: Cur: 0 Init: 0 Shield: Cur: 0 Init: 0 Structure: Cur: 0 Init: 0 Stealth: Cur: 5 Init: 0 Detection Range: Cur: 25 Init: 0 Battle Speed: Cur: 50 Init: 0 Starlane Speed: Cur: 75 Init: 0 design id: 10 fleet id: -1 species name: produced by empire id: 1 fighters: missiles: part meters:
2013-06-15 18:53:07,662 DEBUG Client : MapWnd::InitTurn m_production_wnd refresh time: 1101
2013-06-15 18:53:07,668 DEBUG Client : MapWnd::InitTurn indicators refresh time: 6
2013-06-15 18:53:07,674 DEBUG Client : SelectedShipsChanged starting...
2013-06-15 18:53:07,674 DEBUG Client : MapWnd::UpdateMeterEstimates
2013-06-15 18:53:07,674 DEBUG Client : Universe::GetEffectsAndTargets
2013-06-15 18:53:07,705 DEBUG Client : Type times: planet species: 8 ship species: 16 specials: 2 techs: 1 buildings: 0 hulls/parts: 4 fields: 0
2013-06-15 18:53:07,706 DEBUG Client : Universe::UpdateMeterEstimatesImpl on 4 objects time: 32
2013-06-15 18:53:08,734 DEBUG Client : MapWnd::SelectedShipsChanged time: 1060
2013-06-15 18:53:08,735 DEBUG Client : MapWnd::DispatchFleetsExploring called
2013-06-15 18:53:08,735 DEBUG Client : MapWnd::InitTurn fleet UI refresh and exploring dispatch time: 1067
2013-06-15 18:53:08,736 DEBUG Client : MapWnd::InitTurn time: 5434
2013-06-15 18:53:08,805 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,822 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,837 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,852 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,867 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,882 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:08,899 DEBUG Client : (HumanClientFSM) PlayingGame.PlayerStatus
2013-06-15 18:53:10,276 DEBUG Client : HumanClientApp::HandleFocusChange()
Last edited by yandonman on Sun Jun 16, 2013 2:50 am, edited 1 time in total.
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.
- Geoff the Medio
- Programming, Design, Admin
- Posts: 13587
- Joined: Wed Oct 08, 2003 1:33 am
- Location: Munich
Re: 6142 (Dev build)
Not much use without the log from the turn before the change to compare with... Verbose logs might be more useful, if you can isolate some large-time exobot-specific or relevant-planet-specific things.yandonman wrote:Here's the extended log:
Re: 6142 (Dev build)
My apologies, I am such a dolt. I added the whole turn 1-190 logs to above.
Also here is turn 190 -> 191 (with verbose logging attached)
Also here is turn 190 -> 191 (with verbose logging attached)
Code: Select all
2013-06-15 19:52:07,740 DEBUG Client : MapWnd::InitTurn research wnd refresh time: 73
2013-06-15 19:52:10,486 DEBUG Client : MapWnd::InitTurn sidepanel refresh time: 2746
2013-06-15 19:52:10,487 DEBUG Client : ProductionWnd::UpdateQueue()
2013-06-15 19:52:11,508 DEBUG Client : BuildDesignatorWnd::BuildSelector::Refresh()
2013-06-15 19:52:11,511 DEBUG Client : MapWnd::InitTurn m_production_wnd refresh time: 1025
2013-06-15 19:52:11,520 DEBUG Client : MapWnd::InitTurn indicators refresh time: 9
2013-06-15 19:52:11,520 DEBUG Client : MapWnd::DispatchFleetsExploring called
2013-06-15 19:52:11,520 DEBUG Client : MapWnd::InitTurn fleet UI refresh and exploring dispatch time: 0
2013-06-15 19:52:11,521 DEBUG Client : MapWnd::InitTurn time: 15363
- Attachments
-
- FreeOrion_Verbose.7z
- (282.61 KiB) Downloaded 82 times
Code released under GPL 2.0. Content released under GPL 2.0 and Creative Commons Attribution-ShareAlike 3.0.