[Nov. 20 test build (e6848d8)] Missing info on tech hover

Describe your experience with the latest version of FreeOrion to help us improve it.
Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Message
Author
User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

[Nov. 20 test build (e6848d8)] Missing info on tech hover

#1 Post by alleryn » Fri Nov 24, 2017 8:32 pm

Am i imagining things? When you hover the mouse pointer over a tech, a box pops up with the tech's icon.

I believe that in the latest official release (0.4.7.1) this box displayed info like "Theoretical Prerequisite", "Unlocks Building", etc. Has this info disappeared from those boxes? When i hover i now just get the icon on the left and an empty box.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12268
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#2 Post by Geoff the Medio » Fri Nov 24, 2017 8:58 pm

I see the same issue. Don't see the problem in the code though...

The BrowseWnd is being constructed with the appropriate text passed in, but it's just not being rendered for some reason.

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#3 Post by alleryn » Fri Nov 24, 2017 10:03 pm

Would it have anything to do with GG/src/ListBox.cpp ? I'm not sure if this is a relevant file, but i'm seeing a number of changes to it since the official release version (139ffd9). (I remember it working in 139ffd9, haven't played any versions between these two). This is where my nose is pointing me right now.

Here's a link to the comparison between e6848d8 and 139ffd9 if that's helpful to anyone:
https://github.com/freeorion/freeorion/ ... ...139ffd9


Oh.. i had the numbers or codes or whatever backwards... there's way more changes than i thought, haha.
https://github.com/freeorion/freeorion/ ... ...e6848d8
Last edited by alleryn on Sat Nov 25, 2017 12:32 am, edited 1 time in total.

User avatar
Dilvish
AI Lead, Programmer
Posts: 4712
Joined: Sat Sep 22, 2012 6:25 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#4 Post by Dilvish » Sat Nov 25, 2017 12:21 am

The tech tooltips are still working fine for me on Linux, as of just a few commits ago at least.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#5 Post by alleryn » Sat Nov 25, 2017 6:59 am

Just reporting in that i compiled a more recent build [build 2017-11-24.f5304af] and the tech hover box still appears empty on my (windows 10) machine.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12268
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#6 Post by Geoff the Medio » Sat Nov 25, 2017 10:30 am

It would be helpful if you can narrow down or determine the build or revision that broke them for you.

Edit: does not work for me in d21aa97

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#7 Post by alleryn » Sat Nov 25, 2017 3:52 pm

Geoff the Medio wrote:It would be helpful if you can narrow down or determine the build or revision that broke them for you.

Edit: does not work for me in d21aa97
On it.

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#8 Post by alleryn » Sat Nov 25, 2017 4:59 pm

I narrowed it down using the sourceforge installers.

Working: 139ffd9 (Sept. 3 -- this is the 0.4.7.1 release build). Also works in an earlier test build (the last one before the release candidates) 4e12b03 (Aug. 24)
Not working: 8ee7fb7 (Sept. 4)

For me to narrow it down to a more precise commit, i think i'm going to first need to figure out how to use git.

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#9 Post by dbenage-cx » Sat Nov 25, 2017 8:51 pm

Same as Dilvish here, I do not see any issue.

If you are up to narrowing it further, git bisect would be the tool/feature to use.

Could someone affected open an issue? Preferably with a screen shot if possible.

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#10 Post by alleryn » Sun Nov 26, 2017 12:34 am

dbenage-cx wrote: Could someone affected open an issue? Preferably with a screen shot if possible.
Done. https://github.com/freeorion/freeorion/issues/1878

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#11 Post by dbenage-cx » Sun Nov 26, 2017 2:30 am

Appreciate the detailed report alleryn, thankfully it was the first guess.
Fixed in cbf1e48

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#12 Post by alleryn » Sun Nov 26, 2017 2:38 am

dbenage-cx wrote:Appreciate the detailed report alleryn, thankfully it was the first guess.
Fixed in cbf1e48
Thanks!

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#13 Post by alleryn » Sun Nov 26, 2017 3:15 am

Out of curiosity, any explanation for why windows can't handle the unicode properly while linux can? (If that's the difference between where it was working and where it wasn't).

dbenage-cx
Programmer
Posts: 389
Joined: Sun Feb 14, 2016 12:08 am

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#14 Post by dbenage-cx » Sun Nov 26, 2017 5:34 pm

I can not test to be certain, I believe MSVC is encoding it in CP1252, the equivalent would have been 0x96.
The answer on this SO question has a more detailed explanation, if that is the case.
En dash is probably the "proper" character to use for the separation (or em dash, depending on interpretation), but did not feel it warranted compiler specific handling when the difference with hyphen-minus is not likely to be noticed.
Any content posted should be considered licensed GNU GPL 2.0 and/or CC-BY-SA 3.0 as appropriate.

User avatar
Geoff the Medio
Programming, Design, Admin
Posts: 12268
Joined: Wed Oct 08, 2003 1:33 am
Location: Munich

Re: [Nov. 20 test build (e6848d8)] Missing info on tech hove

#15 Post by Geoff the Medio » Sun Nov 26, 2017 6:13 pm

dbenage-cx wrote:...did not feel it warranted compiler specific handling when the difference with hyphen-minus is not likely to be noticed.
What's wrong with

Code: Select all

u8" \u2013 "

Post Reply