[Sitrep] Systems just de-cloaked

Describe your experience with the latest version of FreeOrion to help us improve it.
Forum rules
Always mention the exact version of FreeOrion you are testing.

When reporting an issue regarding the AI, if possible provide the relevant AI log file and a save game file that demonstrates the issue.
Post Reply
Message
Author
User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

[Sitrep] Systems just de-cloaked

#1 Post by alleryn » Sat Dec 16, 2017 5:12 am

I'm guessing this would be pretty tough to implement, but the situation arises quite often when one is waiting to gain vision of a planet to colonise or invade (usually waiting for an Ion Storm to pass).

It would be pretty nice if this could be integrated into the Sitrep somehow ("The planet xyz has just been sighted" ?). Probably best to wait on this until the next stealth pass, but i thought it was worth mentioning.

User avatar
Vezzra
Release Manager, Design
Posts: 4657
Joined: Wed Nov 16, 2011 12:56 pm
Location: Sol III

Re: [Sitrep] Systems just de-cloaked

#2 Post by Vezzra » Sun Dec 17, 2017 10:19 am

Good idea, but you should probably open a feature request issue for that on github. Ideas like that just left here on the forum have this tendency to get buried and forgotten... ;)

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Sitrep] Systems just de-cloaked

#3 Post by alleryn » Sun Dec 17, 2017 4:27 pm

Vezzra wrote:Good idea, but you should probably open a feature request issue for that on github. Ideas like that just left here on the forum have this tendency to get buried and forgotten... ;)
Will do. My preference is to leave my feature requests on the forum for at least a week ago, in case anyone has ideas to improve them (or points out problems in my original idea).

I'll make a pass now over my old posts to check for any feature requests from the forums that i need to formalize.

Thanks, Vezzra :)

User avatar
Oberlus
Small Juggernaut
Posts: 703
Joined: Mon Apr 10, 2017 4:25 pm

Re: [Sitrep] Systems just de-cloaked

#4 Post by Oberlus » Sun Dec 17, 2017 6:29 pm

Just for the record, I would also like such feature, and have nothing else to add :)

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Sitrep] Systems just de-cloaked

#5 Post by alleryn » Sun Dec 17, 2017 7:41 pm

Just a quick update on what i'm thinking of requesting, as i'm not really sure what the best approach is:

Three new sitrep filters (the last of which may be unnecessary):

1. Unowned Planet Revealed and an Outpost/Colony Ship of your Empire is present in the System.
2. Enemy-owned Planet Revealed and Troop Count of your Fleet at the System is > 0.
3. Any Planet Revealed

[Here Revealed is intended to mean Previous Turn: Stealth > Your Empire Detection, Current Turn: Stealth <= Your Empire Detection]

Jaumito
Space Kraken
Posts: 137
Joined: Tue May 16, 2017 3:42 am
Location: Catalonia, France, Europe, Earth, Sol, Orion Arm, Milky Way, Virgo Cluster

Re: [Sitrep] Systems just de-cloaked

#6 Post by Jaumito » Sun Dec 17, 2017 7:57 pm

Come to think of it, a mere filter for "idle" colony/outpost/troop ships (not moving, weren't produced this turn and didn't arrive at a system this turn) would solve your problem and would be easier to implement.

User avatar
Dilvish
AI Lead, Programmer
Posts: 4712
Joined: Sat Sep 22, 2012 6:25 pm

Re: [Sitrep] Systems just de-cloaked

#7 Post by Dilvish » Sat Dec 23, 2017 8:09 pm

Some interesting ideas, enough to get me digging through the code looking at factors related to implementation for this, and while looking at it I also noted some related sitrep nuances which I think are of particular interest to MatGB (in regards to various damage repair sitreps) and which I have highlighted in the wiki section on Order of Turn Event Processing.

Looks to me like the one key scripting capability that prevents most of this from being scriptable as a personal custom sitrep relates to the visibility info. (But probably in some cases with a one turn delay, see below).

Adding an optional "turn = " clause to the EmpireObjectVisibility ValueRef, could allow for comparing the current visibility of an item to that on the previous turn.

With our current Order of Turn Event Processing, all scripted sitreps are generated as part of the single round of general Effect processing that is done after the post movement&combat visibility updates. So any de-cloaking which is triggered by movement & combat could be caught fine by such a sitrep, but any de-cloaking which is accomplished via an Effect (including indirectly via meter value changes) would not result in a sitrep being delivered until the turn after the visibility change was first directly observable by the player.

That may be rare enough that we simply accept that caveat, or, it could be that we might want to do something about it. Looking into the issue more, it seems related to an aspect of our effect processing that has also allowed damage repair sitreps to get out of sync with the actual damage repaired. It seems to me that a reasonable remedy (at least possible/partial remedy) could be to allow SetMeteter Effects to specify a sitrep subclause, but for at least for this visibility issue that could still allow for some discrepancies because of conflicting Effects. I think I should post an issue about this broader issue of discrepancies between sitreps and related meter changes.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

User avatar
alleryn
Space Kraken
Posts: 112
Joined: Sun Nov 19, 2017 6:32 pm

Re: [Sitrep] Systems just de-cloaked

#8 Post by alleryn » Sun Jan 07, 2018 9:45 am

I'm going to try to keep an eye on Dilvish's github issue and make a request when/if that gets resolved.

Post Reply