Cleanup compatibility code

Programmers discuss here anything related to FreeOrion programming. Primarily for the developers to discuss.

Moderator: Committer

Post Reply
Message
Author
o01eg
Space Kraken
Posts: 197
Joined: Sat Dec 10, 2011 5:46 am

Cleanup compatibility code

#1 Post by o01eg » Sun Dec 16, 2018 5:11 pm

What about to reset serialization version of classes and remove compatibility code?
Currently it doesn't work well even for changes in FOCS scripts because different FOCS gives issues either for multiplayer game or for loaded game which works with the new rules not the saved ones. Changes in master and latest release also cause errors: https://github.com/freeorion/freeorion/issues/2327
Gentoo Linux x64, gcc-7.3, boost-1.65.0
Ubuntu Server 18.04 x64, gcc-7.3, boost-1.65.1
Welcome to multiplayer server at freeorion-test.dedyn.io.Version 0.4.8
Donates are welcome: BTC:14XLekD9ifwqLtZX4iteepvbLQNYVG87zK

User avatar
Dilvish
AI Lead, Programmer
Posts: 4768
Joined: Sat Sep 22, 2012 6:25 pm

Re: Cleanup compatibility code

#2 Post by Dilvish » Sun Dec 16, 2018 9:02 pm

o01eg wrote:
Sun Dec 16, 2018 5:11 pm
What about to reset serialization version of classes and remove compatibility code?
Currently it doesn't work well even for changes in FOCS scripts because different FOCS gives issues either for multiplayer game or for loaded game which works with the new rules not the saved ones. Changes in master and latest release also cause errors: https://github.com/freeorion/freeorion/issues/2327
It seems to me like the issues you cite are rather specific-- you are not pointing to a complete failure of the compatibility code but just a couple of instances. It seems the more robust approach would be to improve the compatibility code, I don't see how ripping it out is going to make your cited issues any better.
If I provided any code, scripts or other content here, it's released under GPL 2.0 and CC-BY-SA 3.0

Post Reply